ci: add main-branch DRA check for minor version-bump workflow - #19381
Open
ninalee12 wants to merge 1 commit into
Open
ci: add main-branch DRA check for minor version-bump workflow#19381ninalee12 wants to merge 1 commit into
ninalee12 wants to merge 1 commit into
Conversation
Adds a generate-master-dra-check step (minor workflow only) that
computes the next minor version and dynamically uploads a
fetch-master-dra-artifacts step to poll master.json for
{major}.{minor+1}.0-SNAPSHOT, confirming the main branch DRA
build has picked up the new version.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
🤖 GitHub commentsJust comment with:
|
Contributor
|
This pull request does not have a backport label. Could you fix it @ninalee12? 🙏
|
💛 Build succeeded, but was flaky
Failed CI Steps |
ninalee12
marked this pull request as ready for review
August 6, 2026 17:21
v1v
reviewed
Aug 27, 2026
v1v
left a comment
v1v
left a comment
Member
There was a problem hiding this comment.
As I mentioned at elastic/beats#52435 (review)
let's move the logic to a BK plugin, why? because BK plugins can simplify the usage, support tests and avoid inline scripts to create dynamic pipeline steps that cannot be tested easily.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During the recent minor version bump (9.5), each team's version-bump pipeline advanced
mainto the next dev minor (9.6.0-SNAPSHOT) in addition to cutting the release branch. The version-bump pipelines currently verify only that the release-branch DRA artifacts landed (staging + snapshot for${BRANCH}.json) — they do not verify that main's DRA snapshot actually published at the new version.This means a minor bump can report success even if main's DRA pipeline never picked up
9.6.0-SNAPSHOT. The gap was identified during the9.5feature freeze. Only ml-cpp and kibana had a main-branch check; this brings the remaining repos up to the same standard.Tracking: elastic/platform-engineering-productivity#3012
What
Adds a two-step sequence, gated on
WORKFLOW=minor:generate-master-dra-check— runs afterfetch-dra-artifacts. Computes the next dev minor fromNEW_VERSION(e.g.9.5.0→9.6.0) and dynamically uploads a child step viabuildkite-agent pipeline upload.fetch-master-dra-artifacts(uploaded at runtime) — pollsmaster.jsonon GCS withelastic/json-watcheruntil.versionequals${next_minor}-SNAPSHOT.Patch and major bumps are unaffected — the
if: build.env("WORKFLOW") == "minor"guard means neither step is uploaded.Notes
master.json(notmain.json).NEW_VERSION, notBRANCH.